[DNR] Test for free disk spaces#26624
Closed
hantangwangd wants to merge 2 commits intoprestodb:masterfrom
Closed
Conversation
This change free disk space for `product-tests-basic-environment` and `spark-integration` which are failing frequently due to disk space issues
Contributor
Reviewer's GuideThis PR refactors and extends materialized view tests to cover stitching and non-stitching access control, adds new drop/rename base table scenarios, enhances the analyzer to respect the data consistency flag, tightens memory plugin tests to expect failures, and integrates the free-disk-space GitHub action to replace manual cleanup. Sequence diagram for materialized view analysis with data consistency flagsequenceDiagram
participant S as "StatementAnalyzer"
participant A as "Analysis"
participant M as "MaterializedViewAnalysisState"
participant D as "MaterializedViewDefinition"
participant Q as "Query"
S->>A: getStatement()
S->>A: getMaterializedViewAnalysisState(table)
S->>M: isNotVisited()
alt Data consistency enabled
S->>S: processMaterializedView(...)
else Data consistency disabled
S->>A: getAccessControlReferences().addMaterializedViewDefinitionReference(...)
S->>D: getOriginalSql()
S->>Q: createStatement(originalSql, parsingOptions)
S->>A: registerMaterializedViewForAnalysis(...)
S->>S: process(viewQuery, scope)
S->>A: unregisterMaterializedViewForAnalysis(table)
end
Class diagram for updated materialized view analysis in StatementAnalyzerclassDiagram
class StatementAnalyzer {
+visitTable(table, scope)
-processMaterializedView(table, name, scope, materializedView)
}
class MaterializedViewAnalysisState {
+isNotVisited()
+isVisited()
}
class Analysis {
+getStatement()
+getMaterializedViewAnalysisState(table)
+getAccessControlReferences()
+registerMaterializedViewForAnalysis(name, table, sql)
+unregisterMaterializedViewForAnalysis(table)
}
class MaterializedViewDefinition {
+getOriginalSql()
}
class Query {}
StatementAnalyzer --> Analysis
StatementAnalyzer --> MaterializedViewAnalysisState
StatementAnalyzer --> MaterializedViewDefinition
StatementAnalyzer --> Query
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[NDR]: test for free disk spaces
Motivation and Context
N/A
Impact
N/A
Test Plan
N/A
Contributor checklist
Release Notes